Skip to content

[Fixes #14095] Upload thumbnails through the UI for the remote spatial datasets#14096

Merged
giohappy merged 4 commits intomasterfrom
ISSUE_14095
Apr 13, 2026
Merged

[Fixes #14095] Upload thumbnails through the UI for the remote spatial datasets#14096
giohappy merged 4 commits intomasterfrom
ISSUE_14095

Conversation

@sijandh35
Copy link
Copy Markdown
Contributor

@sijandh35 sijandh35 commented Apr 3, 2026

Fixes #14095

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Apr 3, 2026
gemini-code-assist[bot]
gemini-code-assist bot reviewed Apr 3, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the set_thumbnail method in geonode/resource/manager.py to allow thumbnail assignment when a thumbnail is explicitly provided, regardless of the resource's default capabilities. The review feedback suggests refining the conditional logic to better handle falsy thumbnail values and avoid unintended automatic generation for resources that do not support it.

Comment thread geonode/resource/manager.py Outdated
@sijandh35 sijandh35 requested a review from mattiagiupponi April 3, 2026 14:23
@mattiagiupponi mattiagiupponi requested review from Gpetrak and mattiagiupponi and removed request for mattiagiupponi April 3, 2026 16:08
Gpetrak
Gpetrak reviewed Apr 7, 2026
View reviewed changes
Comment thread geonode/resource/manager.py Outdated
) -> bool:
_resource = instance or BaseResourceManager._get_instance(uuid)
if _resource and _resource.can_have_thumbnail:
if _resource and (thumbnail or _resource.can_have_thumbnail):
Copy link
Copy Markdown
Member

@Gpetrak Gpetrak Apr 7, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sijandh35 although the fix works fine, we could further improve the code in terms of sustainability and readability.
At first I would rename the property from can_have_thumbnail to the can_set_thumbnail and I would move the logic there as below:

def can_set_thumbnail(self, thumbnail_data=None):
    """
   a simple description
    """
    if thumbnail_data:
        return True
    
    # a comment for clarification
    return self.subtype not in {"3dtiles", "cog", "flatgeobuf"}

and then in the manager we could simply have:

if _resource and _resource.can_set_thumbnail(thumbnail):

As I saw the property can_have_thumbnail is used only in this part.

Copy link
Copy Markdown
Contributor Author

@sijandh35 sijandh35 Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@sijandh35 sijandh35 requested a review from Gpetrak April 13, 2026 07:09
@giohappy giohappy merged commit cab102e into master Apr 13, 2026
16 checks passed
@giohappy giohappy deleted the ISSUE_14095 branch April 13, 2026 09:38
dsuren1 added a commit to dsuren1/geonode that referenced this pull request Apr 15, 2026
@dsuren1
Merge commit 'f8e9fb4585129ad4e028ede61e55e468575207c2' into default_…
f6d5d23 
…format

* commit 'f8e9fb4585129ad4e028ede61e55e468575207c2': (34 commits)
  Fix formatting
  Merge commit from fork
  [Fixes GeoNode#13939] Add support for non-spatial datasets in CSV format in GeoNode (GeoNode#13900)
  build(deps): bump cryptography from 46.0.5 to 46.0.7 (GeoNode#14116)
  Add resourcehandlerinfo creation management command (GeoNode#14118)
  build(deps): update jwcrypto requirement from >=1.5.6 to >=1.5.7 (GeoNode#14127)
  build(deps-dev): update pip requirement from >=19.1 to >=26.0.1 (GeoNode#14125)
  [Fixes GeoNode#14095] Upload thumbnails through the UI for the remote spatial datasets (GeoNode#14096)
  build(deps): bump python-calamine from 0.6.1 to 0.6.2 (GeoNode#14102)
  build(deps): bump django from 5.2.12 to 5.2.13 (GeoNode#14115)
  [Fixes GeoNode#14111] Fix Harvester lookup failure caused by trailing ? during the remote resource upload through the API (GeoNode#14112)
  updated folder for RTD
  [Fixes GeoNode#14097] Label thesaurus is not reloaded on thesaurus changes (GeoNode#14098)
  [Fixes GeoNode#14109] Fixes Dataset creation from JSON Schema fails for LineString (GeoNode#14110)
  Renamed docs folder
  [Fixes GeoNode#14035] Implementation of a common ResourceManager base class for all resource types (GeoNode#14053)
  moving the example in the end of this section
  adding docs for the social account group sync
  [Fixes GeoNode#14042] deprecate overwrite_existing_layers in favor of action… (GeoNode#14043)
  [Fixes GeoNode#13936] Support for XLSX File Uploads in GeoNode (GeoNode#13937)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giohappy giohappy giohappy approved these changes

@mattiagiupponi mattiagiupponi Awaiting requested review from mattiagiupponi

@Gpetrak Gpetrak Awaiting requested review from Gpetrak

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Gpetrak Gpetrak

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Users are not able to upload thumbnails through the UI for the remote spatial datasets

4 participants

@sijandh35 @giohappy @Gpetrak @mattiagiupponi